WIP: Support string templates in Kotlin mode #5609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not willing to walk you through implementing this—but if you read the docs and look at some other modes that have the same issue, I'm sure you can figure it out! |
|
Hm! I saw same issue in 2 modes: Okay! I will try again. I thought you could take a look on my solution. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @marijnh !
Kotlin is supported string templates. A template expression starts with a dollar sign ($) and consists of either a simple name:
Now in kotlin mode we have plain string. I notice the gradle mode supports string templates.
I tried to use the same logic to kotlin mode.
Unfortunately, I do not know the codemirror API.
I would be happy if you give some advice or help with string templates in kotlin mode.
Probably it's actual in C# mode too.
Thanks!